Skip to content

Conversation

@barrettruth
Copy link
Collaborator

Holy crap xd, I am tired of people making prs for tooling here and not in the extras repo

@jfly
Copy link
Collaborator

jfly commented Sep 22, 2025

Sorry, what are the criteria for inclusion here? Do things need some "bake time" in extras before they're admitted here?

@barrettruth
Copy link
Collaborator Author

pretty much every important tool is already in none-ls.nvim. therefore, the rest should more than likely go to extras

@barrettruth
Copy link
Collaborator Author

also, @jfly @mochaaP, thoughts on requiring an approval from someone else before PR merge?

@jfly
Copy link
Collaborator

jfly commented Sep 22, 2025

pretty much every important tool is already in none-ls.nvim. therefore, the rest should more than likely go to extras

How do you know that? And what about the new important tools getting created today (and tomorrow)? I feel like we need some criteria for "this is worthy of promotion to core".

also, @jfly @mochaaP, thoughts on requiring an approval from someone else before PR merge?

If a maintainer sends in a PR, I think it makes sense to wait for an approval from another maintainer.

If a maintainer is reviewing someone else's PR and thinks it's OK, I don't think we need to wait for a second maintainer's opinion.

@mochaaP mochaaP self-requested a review September 22, 2025 21:49
@barrettruth
Copy link
Collaborator Author

fixed and thanks @mochaaP

@barrettruth
Copy link
Collaborator Author

barrettruth commented Sep 24, 2025

@jfly the criteria for inclusion is i can't recall the last time a tool needed to be added to core. and if it really does need to be, someone will disregard the pr note and submit it here anyway.

Look - it literally happened yesterday. 😭

EDIT: totally agree on "criteria for promotion to core." But, I do think this is separate, and that a default pathway from extras -> core promotion makes more sense than a core->extras demotion.

@mochaaP mochaaP merged commit 991e15e into main Sep 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants