-
Notifications
You must be signed in to change notification settings - Fork 112
PR Template #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR Template #301
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Sorry, what are the criteria for inclusion here? Do things need some "bake time" in extras before they're admitted here? |
|
pretty much every important tool is already in none-ls.nvim. therefore, the rest should more than likely go to extras |
How do you know that? And what about the new important tools getting created today (and tomorrow)? I feel like we need some criteria for "this is worthy of promotion to core".
If a maintainer sends in a PR, I think it makes sense to wait for an approval from another maintainer. If a maintainer is reviewing someone else's PR and thinks it's OK, I don't think we need to wait for a second maintainer's opinion. |
|
fixed and thanks @mochaaP |
|
@jfly the criteria for inclusion is i can't recall the last time a tool needed to be added to core. and if it really does need to be, someone will disregard the pr note and submit it here anyway. Look - it literally happened yesterday. 😭 EDIT: totally agree on "criteria for promotion to core." But, I do think this is separate, and that a default pathway from extras -> core promotion makes more sense than a core->extras demotion. |
for more information, see https://pre-commit.ci
Holy crap xd, I am tired of people making prs for tooling here and not in the extras repo